Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can_loop_be_parallelised fails if underlying SymbolicMath comparison produce a TypeError #2723

Open
sergisiso opened this issue Sep 27, 2024 · 1 comment
Labels
bug NG-ARCH Issues relevant to the GPU parallelisation of LFRic and other models expected to be used in NG-ARCH

Comments

@sergisiso
Copy link
Collaborator

sergisiso commented Sep 27, 2024

NEMOv5 (-r ORCA2_ICE_PISCES) mppini.f90

fails in the loop_directive_trans.apply(loop) because it calls the dependency tools dtools.can_loop_be_parallelised and this does a symbolic comparison that fails with:

  File "psyclone/core/symbolic_maths.py", line 203, in _subtract
    return simplify(sympy_expressions[0] - sympy_expressions[1])
                    ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
TypeError: unsupported operand type(s) for -: 'One' and 'tuple'
@LonelyCat124 LonelyCat124 added bug NG-ARCH Issues relevant to the GPU parallelisation of LFRic and other models expected to be used in NG-ARCH labels Sep 27, 2024
@hiker
Copy link
Collaborator

hiker commented Sep 29, 2024

How is that file pre-processed? And what PSyclone script do you use (and any other command line option that might be required).

ATM I can't even process that file with fparser:

File: 'mppini.F90'
Syntax error: at line 182
>>>     READ_NML_REF(numnam,nammpp)

Looks like I need additional #include files as well (# include "read_nml_substitute.h90" :) ). Could you perhaps just give me the pre-processed file, I don't have a full NEMO environment at hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NG-ARCH Issues relevant to the GPU parallelisation of LFRic and other models expected to be used in NG-ARCH
Projects
None yet
Development

No branches or pull requests

3 participants