You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We had the same problem on the PSyIR Nodes and Symbols kwargs, and the Transformations options which are passed to the super class. I don't like having them duplicated as we never check them when they are updated, or when new arguments added to the subclasses, and would be quite hard to review.
Adding a link to the super() is a good and simple solution (which some IDEs, static type tools may be able to follow).
There is a more complex solution of programmatically modifying the __doc__ to include the BASE.__doc__ or even spit __doc__ to separate the kwargs so that they can be included in the subclass docsting, but this may be over-engineering it, and probably not for this PR.
We had the same problem on the PSyIR Nodes and Symbols kwargs, and the Transformations options which are passed to the super class. I don't like having them duplicated as we never check them when they are updated, or when new arguments added to the subclasses, and would be quite hard to review.
Adding a link to the super() is a good and simple solution (which some IDEs, static type tools may be able to follow).
There is a more complex solution of programmatically modifying the
__doc__
to include theBASE.__doc__
or even spit__doc__
to separate the kwargs so that they can be included in the subclass docsting, but this may be over-engineering it, and probably not for this PR.Originally posted by @sergisiso in #2692 (comment)
The text was updated successfully, but these errors were encountered: