Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture Performance vs Test Name #267

Open
titusfortner opened this issue Jul 21, 2021 · 1 comment
Open

Capture Performance vs Test Name #267

titusfortner opened this issue Jul 21, 2021 · 1 comment
Assignees
Labels
java Java Bindings

Comments

@titusfortner
Copy link
Collaborator

titusfortner commented Jul 21, 2021

Right now Java errors if capture performance is set without setting test name, but with the test runners this is set automatically after the session is created, requiring users to set it. We should remove the check in the setter and put it in the capability conversion method.

@nadvolod
Copy link
Collaborator

@titusfortner we should fix this bug, our current Performance example is weird as it's really tough to set a good test name per test as it's implemented in.

   @Override
    public SauceOptions createSauceOptions() {
        return SauceOptions.chrome()
                .setExtendedDebugging()
                .setName("PerformanceTest") // bug - https://github.com/saucelabs/sauce_bindings/issues/267
                .setCapturePerformance()
                .build();
    }

I didn't take a long look, not sure if you know of a work around?

@titusfortner titusfortner self-assigned this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Java Bindings
Projects
None yet
Development

No branches or pull requests

2 participants