Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establishing connections only through an external Socks5 proxy cannot be enforced all the time #1073

Open
srossbach opened this issue Jul 31, 2020 · 0 comments
Labels
Area: Core Issue affecting the Saros Core Prio: Medium State: Wontfix Type: Bug Issue that describes an unintended behavior of Saros

Comments

@srossbach
Copy link
Contributor

srossbach commented Jul 31, 2020

This is an issue in the XEP specification and there is currently no way to solve this without breaking other networks stacks (although we only have XMPP for now)

Steps to reproduce:

On the inviter (ALICE) side ensure that you want only to establish connections through an external proxy.
On the invitee (BOB) side allow all connections.

If ALICE invites BOB then ALICE IP will be exposed because the connect call in the ISN to ALICE works vice versa for Socks5. i.e BOB will tell ALICE to connect to him.

If BOB invites ALICE the external (if available) Socks5 proxy will be used.

To solve the issue the connect call has to be moved from the ISN to OSN. However regarding an server-client architecture this is likely not very easy to understand and will fail if you introduce other network stacks.

@srossbach srossbach added Type: Bug Issue that describes an unintended behavior of Saros Area: Core Issue affecting the Saros Core Prio: Medium State: Wontfix labels Jul 31, 2020
@srossbach srossbach changed the title Establishing connection only though an external Socks5 cannot be enforced all the time Establishing connections only though an external Socks5 cannot be enforced all the time Jul 31, 2020
@srossbach srossbach changed the title Establishing connections only though an external Socks5 cannot be enforced all the time Establishing connections only through an external Socks5 cannot be enforced all the time Jul 31, 2020
@srossbach srossbach changed the title Establishing connections only through an external Socks5 cannot be enforced all the time Establishing connections only through an external Socks5 proxy cannot be enforced all the time Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Issue affecting the Saros Core Prio: Medium State: Wontfix Type: Bug Issue that describes an unintended behavior of Saros
Projects
None yet
Development

No branches or pull requests

1 participant