-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs]: Documentation Light/Dark Theme #79
Comments
@majamarijan sorry no one ever got back to you on this I've been spending some time cleaning up issues and updating the website. Is this still happening for you? I was unable to reproduce |
Hi @brookslybrand! Yes, it is better (Chrome and Firefox), but the issue still exists => when change the theme and then click on the bookmark. Clicking on the blank space on the page doesn't affect the theme anymore. That's corrected well! |
@majamarijan, are you toggling your network speed or anything? I'm wondering if the action is getting cancelled before the cookie has a chance to update? |
@brookslybrand , no toggling. Yeah, I think that's the problem. If the theme is changed, and I click on the bookmark in a half a second or less after changing the theme, then this happens. Or, I change the Theme and then double click on the bookmark (like # Tutorial). I do the same on the MDN website and this is not happening (they have the same theme button that opens a dialog). Yet, it is now much better than before. |
Describe what's incorrect/missing in the documentation
I noticed some misbehavior in the functionality when changing themes in React Router Docs.
The theme is changing back or back and forth between dark/light when you:
This is checked on both Chrome (Version 118.0.5993.117 ) and Firefox (Version 118.0.5993.117 )
The text was updated successfully, but these errors were encountered: