Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize dockerBuildImageName #182

Open
bwplotka opened this issue May 19, 2020 · 0 comments
Open

Parametrize dockerBuildImageName #182

bwplotka opened this issue May 19, 2020 · 0 comments

Comments

@bwplotka
Copy link
Member

It would be nice to parameterize promu to use different golang builder image, plus make you we push golang builder to dockerhub as well here:

promu/cmd/crossbuild.go

Line 32 in d629dfc

dockerBuilderImageName = "quay.io/prometheus/golang-builder"

Rationales:
quay.io is down for ~day and our CI is using promu crossbuild, it would be nice to be able to quickly switch to dockerhub in those cases. (: Otherwise we are kind of stuck: thanos-io/thanos#2631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bwplotka