Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case issues #252

Open
inferiorhumanorgans opened this issue Jul 30, 2022 · 1 comment
Open

Test case issues #252

inferiorhumanorgans opened this issue Jul 30, 2022 · 1 comment

Comments

@inferiorhumanorgans
Copy link

ABNF:

metric-descriptor =/ HASH SP help SP metricname SP escaped-string LF

bad_help_2 (should fail):

# HELP a
# EOF

empty_metadata (should pass):

# HELP a
# UNIT a
# EOF
@brian-brazil
Copy link
Contributor

I've double checked, and both those tests are handled correctly. Note the trailing space on the HELP line on the passing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inferiorhumanorgans @brian-brazil