Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is possible to specify conflicting info on ad units and ortb2imp #12166

Open
patmmccann opened this issue Aug 22, 2024 · 4 comments
Open

It is possible to specify conflicting info on ad units and ortb2imp #12166

patmmccann opened this issue Aug 22, 2024 · 4 comments

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Aug 22, 2024

It is possible to do this:

pbjs.requestBids({ adUnits: [{ code: 'test-div', mediaTypes: { banner: { sizes: [[300,250]], battr = [3] } }, ortb2Imp: { banner: { battr = [4] } } }] });

And many publishers specify params for imp.video.* in the mediatype.video object, not the ortb2Imp.video object.

Some adapters look for battr in the latter (ttd), some in the former (pubmatic) and most just use params (we need to clean that up).

Proposal: the ortb2Imp object in the bid request contains the full banner and video objects from the mediatype, and vice versa, but conflicts always resolve to the media type.

This has some impacts on PAAPI bidders, which are reliant on ortb2Imp being detailed

@dgirardi
Copy link
Collaborator

dgirardi commented Aug 22, 2024

the ortb2Imp object in the bid request contains the full banner and video objects from the mediatype,

in general mediaTypes are not valid ortb. mediaTypes.video is almost like imp.video but not quite. banner and especially native are very different.

We can do this only for specific fields that we decide should be mirrored. Or we could move parts of ortbConverter into core to do the translation for everyone.

@pm-harshad-mane
Copy link
Contributor

And many publishers specify params for imp.video.* in the mediatype.video object, not the ortb2Imp.video object.

We, Prebid, can keep only one way of defining these params ( a major version change ), preferably through ortb2Imp.

@patmmccann
Copy link
Collaborator Author

the ortb2Imp object in the bid request contains the full banner and video objects from the mediatype,

We can do this only for specific fields that we decide should be mirrored.

Doh, let's scope this down to just battr and these ones https://github.com/prebid/Prebid.js/pull/11970/files#diff-a4386e7142e703699b5a905fc06783725a5eccecb33fa0b1f6b5ab4466fb8286 ?

@patmmccann
Copy link
Collaborator Author

outcome: ortb2Imp should win in the case of conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Dev
Development

No branches or pull requests

3 participants