Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server in single-port mode stops responding if non-existing file requested #99

Open
waldner opened this issue Oct 16, 2024 · 1 comment · May be fixed by #100
Open

Server in single-port mode stops responding if non-existing file requested #99

waldner opened this issue Oct 16, 2024 · 1 comment · May be fixed by #100

Comments

@waldner
Copy link

waldner commented Oct 16, 2024

When using single-port mode, using the provided sample code for the readHandler, as long as existing files are requested, everything works fine. When a non-existent file is requested, the open nofile: no such file or directory message is displayed, err is returned but then subsequent requests from the client are just ignored.

@waldner waldner linked a pull request Oct 18, 2024 that will close this issue
@waldner
Copy link
Author

waldner commented Oct 18, 2024

So it turns out this was due to a misbehaving tftp client, which was sending an unexpected ACK after an error was received from the server, corrupting the server status and preventing it from processing further packets. The RFC is pretty clear that error packets should not be acknowledged.
Even if this is due to a bad client, I think the fix is simple and helps making the code more robust, so I've opened #100 with what I believe is the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant