Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return list of edits rather than full string #158

Open
shaunlebron opened this issue Jul 27, 2017 · 5 comments
Open

return list of edits rather than full string #158

shaunlebron opened this issue Jul 27, 2017 · 5 comments

Comments

@shaunlebron
Copy link
Collaborator

could help the speed of the ports by removing the time spent on string allocation/manipulation?

Colin is working on this one I believe

This new edits result can be used in addition to the text result, which may be able to be derived from edits only when some returnFullText option is enabled

@DogLooksGood
Copy link

Some emacs plugins will attach stlyles to text in the editor(they called overlay). These overlay will disappear when the text get deleted.

For example, in emacs cider-mode(clojure plugin), type C-u C-c C-c, you will evaluate current top level defn, let it break for debugging when called. And cider will add a red box to the function name to indicate this function is debugging. when you delete the defn(delete the text), the redbox will be deleted too(no text to attach).

so when parinfer returns full text, you have to delete all text at first, so you lose all the overlay in these buffer.

@shaunlebron
Copy link
Collaborator Author

what causes the overlay to refresh?

@shaunlebron
Copy link
Collaborator Author

@DogLooksGood
Copy link

the refresh stratedy is depend on the plugin. there's no way to let them do refresh. changed lines can fix this problem.

@shaunlebron
Copy link
Collaborator Author

See PR #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants