Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring clean up: detect and delete dead scripts #1531

Open
pitag-ha opened this issue Apr 15, 2021 · 10 comments · May be fixed by #1538 or #1580
Open

Spring clean up: detect and delete dead scripts #1531

pitag-ha opened this issue Apr 15, 2021 · 10 comments · May be fixed by #1538 or #1580
Labels
medium More Complex Issues for Outreachy

Comments

@pitag-ha
Copy link
Member

There are a couple of scripts that seem to be dead code, e.g. ocamlapplet.bash and link_blog_doc_ext.sh. I propose that someone goes through all scripts in the script/ folder and finds and deletes the ones that don't have an impact anymore.

How

There are different ways to check if a script still has an impact (on the build). One option would be to build the page as is and save the result, then remove the script and build the page again, and then make a recursive diff on the two results.

Watch out

In the first run, you might wrongly detect scripts that are meant for development as dead code. Have a look if the scripts you detect are used for development.

@dldisha
Copy link

dldisha commented Apr 15, 2021

Hey @pitag-ha , I'm interested in working on this issue. Can I give it a try?

@patricoferris patricoferris added the medium More Complex Issues for Outreachy label Apr 16, 2021
@pitag-ha
Copy link
Member Author

@dldisha, sure, go ahead :)

@dldisha dldisha linked a pull request Apr 16, 2021 that will close this issue
4 tasks
@dldisha
Copy link

dldisha commented Apr 16, 2021

@pitag-ha, please review my code changes.

@pitag-ha
Copy link
Member Author

Thanks for your work on this @dldisha :) What has been your approach to find out if a script is still having an impact on the site or not?

@gurleennsidhuu
Copy link
Contributor

Hi @dldisha. Are you still working on this issue? :)

@jyotibalodhi
Copy link
Contributor

Hello @pitag-ha @patricoferris, I am interested to work on the issue. If anyone is still not working on this issue, can you please assign this to me? Thanks :)

@pitag-ha
Copy link
Member Author

pitag-ha commented May 3, 2021

Hi @jyotibalodhi, we can't guarantee that we could help out with questions and review/merge a PR soon, but if no one else is working on this issue, feel free to work on it! :) @dldisha, @gurleennsidhuu, is anyone of you working on this?

@gurleennsidhuu
Copy link
Contributor

Hi @jyotibalodhi, we can't guarantee that we could help out with questions and review/merge a PR soon, but if no one else is working on this issue, feel free to work on it! :) @dldisha, @gurleennsidhuu, is anyone of you working on this?

Hi. I have not yet started working on this as I was waiting for @dldisha's reply. If she's not working on this, I would like to start working. Thanks. :)

@jyotibalodhi
Copy link
Contributor

No problem @pitag-ha !! I would love to work on some issues though. :) @gurleennsidhuu sure, you can go ahead, and if you face any issues, I would be happy to help.

@Srinithyee
Copy link
Contributor

@gurleennsidhuu you might want to check out @dldisha's PR #1538 for some leads on the same issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium More Complex Issues for Outreachy
Projects
None yet
6 participants