-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nextslide-directive after sub-Header goes wrong #102
Comments
This bug is related to #100, as it is only visible when that one is (partially) fixed. |
…) when using headers above auto-slide-level (bug nyergler#100)
I read through the diff between your master branch and master in this repo. Overall it looks reasonable. A few things I noticed generally:
Want to take a run at automating the test assertions and open a PR? |
Thanks. An some answers TestsI used and added those tests for two reasons: Firstly, I didn’t understand the test-suite; so, some guidance will help. And secondly, I didn’t what to test (only) at unitlevel (which, as far as I understand, the existing test did). I wanted to improve the result: the looks of the slides. So I created a (mini) hieroglyph project to and made sure the slides come out nicely. However, if that can be done; please help! CSSYeah, I made some changes to the CSS; for the same reason as above: the result counts. The “new” H3 level sub-header wasn’t properly shown, so I had to to make it … About the scrolling: I had a long though about it. But a the end I decided that it was needed. Let me shown the link of thought:
Firstly, I implemented it in my local css-style. But decided it is more general and made it public. An alternative is, to make it (scroll/scale/as-is) a config-option. Hoever, that would need extra infra-structure to parse/render the “static” pages too. Which by itself would be handy; by example to set the geometry (width/height) of the slides. But for now: to much. DocsStarted on that, specially for (GIO) slides2. But it is done and should be in the master branch yet. But copy and use anything you like (see my DOC-gio_slides branch) Pull RequestPlease guide with the test automation, and I will make a PR (when it passes all test) Also, please run this version on existing projects/slide-desks, to make sure nothing is broken. Yes, I like quality:-) |
A bit of refinement is done around the scrolling option. It's available in my GAM-dev branch. Didn't merge it to master yet |
BUGDEMO
Note: For this demo the conf should contain
slide_levels = 2
AutoSlide
Use only as sub-header, not as nextslide header
echo h3
.. nextslide::
:increment:
This should be on a new slide, named
AutoSlide (2)
, not of the last h3The text was updated successfully, but these errors were encountered: