Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all ESlint warnings #45

Open
nt1m opened this issue Aug 29, 2015 · 7 comments
Open

Fix all ESlint warnings #45

nt1m opened this issue Aug 29, 2015 · 7 comments
Labels

Comments

@nt1m
Copy link
Owner

nt1m commented Aug 29, 2015

There are 2 main warnings :

  • no-unused vars : ESlint doesn't seem to support React properly, we can either ignore those warnings, or disable the ESlint rule
  • strict : ESlint wants all the files to have "use strict";, what do you think @mdibaiee ?
@mdibaiee
Copy link
Collaborator

About no-unused-vars, I think we might want to disable that, if we were using modules, it would be ok as eslint understands exports.

I only see one warning about strict which says main.jsx should not have a "use strict" directive. Other than that, I don't see any errors. Are you running grunt eslint?

@nt1m
Copy link
Owner Author

nt1m commented Aug 29, 2015

@mdibaiee Yep, I'm running grunt eslint. And it displays the warning for all the files not having the "use strict" header.

@nt1m
Copy link
Owner Author

nt1m commented Aug 29, 2015

About 25 warnings are dedicated to strict

@mdibaiee
Copy link
Collaborator

@nt1im that was fast 😁

This is the result of grunt eslint for me: https://gist.github.com/mdibaiee/9d0a918ab57653d01262

@nt1m
Copy link
Owner Author

nt1m commented Aug 29, 2015

@mdibaiee I should be sleeping right now ;)
Here's my grunt eslint result : https://gist.github.com/nt1m/5d7cca0d4bbf73474b8c (I have some changes locally, but they only give 1 or 2 extra warnings)
Maybe we have different versions of eslint ?

@mdibaiee
Copy link
Collaborator

I'm using version 0.24.1. I couldn't sleep.

@nt1m
Copy link
Owner Author

nt1m commented Aug 29, 2015

@mdibaiee Me too, I wonder what's going on.

@nt1m nt1m added the cleanup label Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants