Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occasional issue with conditionvariable specs #1966

Open
herwinw opened this issue Apr 5, 2024 · 3 comments
Open

Occasional issue with conditionvariable specs #1966

herwinw opened this issue Apr 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@herwinw
Copy link
Member

herwinw commented Apr 5, 2024

Example: https://github.com/natalie-lang/natalie/actions/runs/8569056088/job/23484139786

 FAIL ruby/spec::spec/core/conditionvariable/signal_spec.rb#test_0001_passes all specs (2901.91s)
        Expected #<Process::Status: pid 18873 exit 1> to be success?.
        /natalie/test/ruby/ruby_specs_test.rb:35:in `block (4 levels) in <top (required)>'

Once in a while this spec fails. Most times a retry resolves this issue, but it would be nice to not have this issue in the first place.

@herwinw herwinw added the bug Something isn't working label Apr 5, 2024
@herwinw
Copy link
Member Author

herwinw commented Apr 7, 2024

Not sure if it is related, but the MacOS test is often taking about 2h30m to finish, which is roughly double that of the Linux runs.

@herwinw
Copy link
Member Author

herwinw commented Jun 8, 2024

I'm tempted to close this one, I can't remember having seen this issue in a long time, so I guess it has been fixed by accident (either because we fixed something else, or an update of something in the toolchain on Darwin)

@seven1m
Copy link
Member

seven1m commented Jun 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants