Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good job! #147

Open
jwall-ys opened this issue Mar 28, 2021 · 2 comments
Open

Good job! #147

jwall-ys opened this issue Mar 28, 2021 · 2 comments

Comments

@jwall-ys
Copy link

Hey,

Not really sure where to put this but I just wanted to say thank you to everyone involved in getting the licensing issue resolved as quickly as it did. It was a complicated/tense situation and it was handled admirably.

We were literally sitting on a call wondering what to do with the nokogiri version and just like magic (no pun intended with the gem name ;) ) '0.3.8' popped up when we refreshed rubygems and it solved our build issue.

I also applaud the decision to make the error about the missing DB file on install. I was reading what the solution to be able to get back to an MIT license and was wondering what would happen if that file wasn't there. I got a little antsy when our build just started working and I didn't know if our environments had that file or not. Once I installed it on a fresh system and got the install error I breathed a BIG sigh of relief because that was a strong indicator we wouldn't have any regression issues with the new loading strategy.

Good job, good rally, and I learned a lot!

Thanks!

@valscion
Copy link

I'd also like to sincerely offer my thanks to @jellybob for resolving the license havok gracefully and with haste ☺️

I'd also like to wish for strength for the maintainers for handling the comments that are bound to come for some time caused by this ecosystem-level earthquake. 💞

@mimemagicrb mimemagicrb deleted a comment from johnnyshields Mar 29, 2021
@Insood
Copy link

Insood commented Mar 29, 2021

Indeed - thanks!

@mimemagicrb mimemagicrb deleted a comment from Nytelife26 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants