Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoding error: VectorType not supported yet #182

Open
springmeyer opened this issue Jun 21, 2024 · 1 comment
Open

Decoding error: VectorType not supported yet #182

springmeyer opened this issue Jun 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@springmeyer
Copy link
Collaborator

This error impacts only the vectorized decoder:

MltDecoderTest > currentlyFailingBingDecoding1() FAILED
    java.lang.IllegalArgumentException: VectorType not supported yet: CONST
        at com.mlt.decoder.vectorized.VectorizedPropertyDecoder.decodeToRandomAccessFormat(VectorizedPropertyDecoder.java:169)
        at com.mlt.decoder.MltDecoder.decodeMlTileVectorized(MltDecoder.java:165)
        at com.mlt.decoder.MltDecoderTest.testTile(MltDecoderTest.java:199)
        at com.mlt.decoder.MltDecoderTest.currentlyFailingBingDecoding1(MltDecoderTest.java:72)
springmeyer added a commit to springmeyer/maplibre-tile-spec that referenced this issue Jun 21, 2024
@springmeyer
add a note about maplibre#182
4db97cd
@springmeyer springmeyer added the bug Something isn't working label Jun 21, 2024
@springmeyer springmeyer mentioned this issue Jun 21, 2024
Merged
2 tasks
@springmeyer
Copy link
Collaborator Author

One curious thing about this failure to note: it replicates in the unit tests for the decoder. But I could not replicate with the encode.jar command. When I saw this I then modified the encode.jar to encode the tile in the same way as the decoder unit tests encode the MLT but I was still not able to replicate. So I figure that means either there was a difference still in the way the encode.jar did encoding or something more subtle is happening causing a difference in code paths during decoding.

springmeyer added a commit that referenced this issue Jun 25, 2024
@springmeyer
Test additional code paths in java decoder (#180)
b3edfa4 
Currently we do not fully test all these combinations:

 - Vectorized path + advanced encodings
 - Vectorized path + without advanced encodings
 - Non-Vectorized path + advanced encodings
 - Non-Vectorized path + without advanced encodings
 
This PR starts testing all those paths.

The code coverage changes are:

 - **overall:** `36%`to `45%`
 - **mlt.converter:** `64%` to `85%`
 - **mlt.decoder:** `55%` to `71%`

In addition this PR includes:

- Some refactoring in TestUtils.java to share more code between
vectorized and non-vectorized
- Improvements to TestUtils.java around geometry comparisons (refs #178)
 - Improvements to TestUtils.java around property comparisons

Finally, this PR does not attempt to solve any bugs. Rather it finds,
isolates, and writes tests harnesses to capture them in code. Once bugs
are solved in the future it should be easy to update the tests
accordingly.

TODO:
- [x] ~This PR uncovered a number of bugs that do not have open issues
and did not have tests that hit them until now. So I need to create
following issues to capture fixing these.~
     - Added:
        - #181
        - #182 
        - #183 
        - #184
        - #185
        - #186
- [ ] Property nesting in MLT makes comparison to MVT difficult so I
disabled it in this test refactor because comparison to MVT is what the
decoder tests rely on. My sense is that standalone unit tests of nesting
might be more appropriate than including nesting in the decoder tests.
Do others agree?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@springmeyer