Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Update/Personalize favicon #265

Closed
1 task done
jrhedman opened this issue Aug 11, 2023 · 5 comments
Closed
1 task done

[FEAT] Update/Personalize favicon #265

jrhedman opened this issue Aug 11, 2023 · 5 comments

Comments

@jrhedman
Copy link

Is this a new feature request?

  • I have searched the existing issues

Wanted change

I'd love it if we could update the favicon to our own image/ico file.

Reason for change

I think this would help increase personalization of calibre-web, similar to how we can update the website's title.

Proposed code change

No response

@github-actions
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@jrhedman jrhedman changed the title Update/Personalize favicon [FEAT] <title> [FEAT] Update/Personalize favicon Aug 11, 2023
@aptalca
Copy link
Member

aptalca commented Aug 11, 2023

That's really a request for the upstream project

@jrhedman
Copy link
Author

That's really a request for the upstream project

Linuxserver uses this project then right?

It did find this issue where they mentioned they'd rather have people update the file manually. But from my basic understanding of how docker works, if I update my image, then these changes would be overwritten wouldn't they?

@aptalca
Copy link
Member

aptalca commented Aug 11, 2023

They would be.

Here are some ways to make them permanent:
https://www.linuxserver.io/blog/2019-09-14-customizing-our-containers

@jrhedman
Copy link
Author

Thanks for pointing me in the right direction. I'll close this as under the wrong project/no code change required.

Thanks for your help.

@jrhedman jrhedman closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants