Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send assumes connection is established for channel. #113

Open
cmeiklejohn opened this issue Nov 3, 2017 · 2 comments
Open

Send assumes connection is established for channel. #113

cmeiklejohn opened this issue Nov 3, 2017 · 2 comments

Comments

@cmeiklejohn
Copy link
Member

Right now, in do_send_message in the default peer service manager, it's assumed that if a node is connected, that a connection is open for the channel.

Options:

  • Since the default channel is always the first established, use the default channel for the message if a message specific channel has not been established yet; or
  • Buffer the message until the channel for those types of messages is established.

Thoughts? @slfritchie @seancribbs @tsloughter

@seancribbs
Copy link
Contributor

What sorts of guarantees does a channel provide? If there's an expectation of linearizability of a sequence of messages from the same origin process over the channel, I would not take option A. If the default channel is overloaded (or buffering, or changing window size, etc), you could have messages delivered out of order.

@aramallo
Copy link
Collaborator

Partisan currently uses option A, ie fallbacks to the default channel connection.

In v5.0.0-beta we have fast connection status checks by channel, so we can use this to implement option B or any other option.

I would like to have this to be managed by user prefs ie decision to fallback in default channel or to queue messages by channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants