Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON schema for ambassadors.json #755

Open
2 tasks
DavidBiesack opened this issue Jun 14, 2024 · 6 comments
Open
2 tasks

Add JSON schema for ambassadors.json #755

DavidBiesack opened this issue Jun 14, 2024 · 6 comments
Assignees
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: In Progress This issue is being worked on, and has someone assigned. Status: Stale It's believed that this issue is no longer important to the requestor.

Comments

@DavidBiesack
Copy link
Contributor

Work Summary:

I suggest this repository include a JSON Schema next to the programs/ambassadors/ambassadors.json file (such asprograms/ambassadors/ambassadors-schema.json ). When adding a submission, I was not sure what values I can use for contribution.type - a schema would tell me if it is an enum or an open string value 🙂

Completing this work will mean contributors know how to submit a PR. Plus, this will highlight a good use of JSON Schema.

Do you think this work might require an Architectural Decision Record (ADR)? (significant or noteworthy)

No

Work Detail:

  • add a JSON Schema for the ambassadors.json file
  • Add a github action to validate the ambassadors.json file against the schema
@benjagm benjagm added ✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Available No one has claimed responsibility for resolving this issue. labels Jun 14, 2024
@json-schema-org json-schema-org deleted a comment from ramishj Jun 19, 2024
@benjagm
Copy link
Collaborator

benjagm commented Jun 19, 2024

Great idea David. Thanks!

@ramishj are you available to work on this?

@ramishj
Copy link
Contributor

ramishj commented Jun 19, 2024

yes i have already done it should i push it ? Assign me i will push it

@ramishj
Copy link
Contributor

ramishj commented Jun 19, 2024

Can you assign it to me?

@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Available No one has claimed responsibility for resolving this issue. labels Jun 19, 2024
@benjagm
Copy link
Collaborator

benjagm commented Jun 19, 2024

All yours @ramishj . Thanks a lot for your support!

@ramishj
Copy link
Contributor

ramishj commented Jun 25, 2024

All yours @ramishj . Thanks a lot for your support!

Your Welcome

Copy link

Hello! 👋

This issue has been automatically marked as stale due to inactivity 😴

It will be closed in 180 days if no further activity occurs. To keep it active, please add a comment with more details.

There can be many reasons why a specific issue has no activity. The most probable cause is a lack of time, not a lack of interest.

Let us figure out together how to push this issue forward. Connect with us through our slack channel : https://json-schema.org/slack

Thank you for your patience ❤️

@github-actions github-actions bot added the Status: Stale It's believed that this issue is no longer important to the requestor. label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: In Progress This issue is being worked on, and has someone assigned. Status: Stale It's believed that this issue is no longer important to the requestor.
Projects
Status: In Progress
Development

No branches or pull requests

3 participants