Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use native ISO 8601 date formatter #30

Merged
merged 1 commit into from
Feb 19, 2024
Merged

fix: use native ISO 8601 date formatter #30

merged 1 commit into from
Feb 19, 2024

Conversation

uhthomas
Copy link
Contributor

Fixes: #29

@LePips LePips merged commit 0b20f25 into jellyfin:main Feb 19, 2024
LePips added a commit to LePips/jellyfin-sdk-swift that referenced this pull request Feb 19, 2024
@LePips
Revert "fix: use native ISO 8601 date formatter (jellyfin#30)"
f2aada9 
This reverts commit 0b20f25.
@LePips
Copy link
Member

LePips commented Feb 19, 2024

Oops, I merged without checking if this even compiled. ISO8601DateFormatter is not a DateFormatter, we would need to implement via a dateDecodingStrategy/dateEncodingStrategy = .custom { ... }.

Revert commit: f2aada9

@LePips LePips mentioned this pull request Feb 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use native ISO 8601 date formatter
2 participants
@uhthomas @LePips