Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements Prediction Mask for Pixel Classification #65

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Implements Prediction Mask for Pixel Classification #65

wants to merge 1 commit into from

Conversation

Tomaz-Vieira
Copy link

This still doesn't work as a backwards compatible macro,
since using pixel classification as a macro will require the
value for 'useMask'.

I could not find a way to have this extra parameter with a default
value that would be picked up also by the macro usage. Either
the input is marked as resolved and doesn't show up in the UI,
or it is not marked as resolved, but requires the macro usage to specify
the value interactively.

fixes #7

@Tomaz-Vieira
Implements Prediction Mask for Pixel Classification
5713a86 
This still doesn;t work as a backwards compatible macro,
since using pixel classification as a macro will require the
value for 'useMask'.

I could not find a way to have this extra parameter with a default
value that would be picked up also by the macro usage. Either
the input is marked as resolved and doesn't show up in the UI,
or it is not marked as resolved, but requires the macro usage to specify
the value interactively.
imagejan
imagejan reviewed Jul 30, 2020
View reviewed changes
src/main/java/org/ilastik/ilastik4ij/ui/IlastikPixelClassificationCommand.java
required = false,
description = "An image with same dimensions as Raw Data, where the black pixels will be masked out of the predictions"
)
public Dataset predictionMask;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try:

Suggested change
public Dataset predictionMask;
public Dataset predictionMask = null;

to see whether that solves the issue with a default value?

@k-dominik
Copy link
Contributor

k-dominik commented Jul 30, 2020 •
edited
Loading

I'm also hitting an error with the ci, anyone know how to resolve it?

[ERROR]     Non-resolvable parent POM for org.ilastik:ilastik4ij:1.7.4-SNAPSHOT:
Could not transfer artifact org.scijava:pom-scijava:pom:26.0.0
from/to scijava.public (https://maven.scijava.org/content/groups/public):
Transfer failed for https://maven.scijava.org/content/groups/public/org/scijava/pom-scijava/26.0.0/pom-scijava-26.0.0.pom
500 Server Error and 'parent.relativePath' points at no local POM @ line 5, column 13

looks like we reference a dependency that's not there anymore (since yesterday?!)

@imagejan
Copy link
Contributor

I'm also hitting an error with the ci, anyone know how to resolve it?

That's a temporary issue with server hosting maven.scijava.org.
As far as I know, @ctrueden is on it to fix the problem. I'd recommend waiting until tomorrow and then re-starting the travis build.

@k-dominik
Copy link
Contributor

I'm also hitting an error with the ci, anyone know how to resolve it?

That's a temporary issue with server hosting maven.scijava.org.
As far as I know, @ctrueden is on it to fix the problem. I'd recommend waiting until tomorrow and then re-starting the travis build.

phew, thank you @imagejan I already saw myself editing xml files...

@imagejan imagejan mentioned this pull request Jul 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imagejan imagejan imagejan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow optional prediction mask for pixel classification
3 participants
@Tomaz-Vieira @k-dominik @imagejan