Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate thanos_ metrics prefix #4241

Open
lamida opened this issue Feb 14, 2023 · 2 comments
Open

Deprecate thanos_ metrics prefix #4241

lamida opened this issue Feb 14, 2023 · 2 comments

Comments

@lamida
Copy link
Contributor

lamida commented Feb 14, 2023

Is your feature request related to a problem? Please describe.

There are some metrics exposed by Mimir which have thanos_ as the prefix. That happens due to we are using some package from Thanos, specifically the cache package.

Example:

thanos_cache_dns_failures_total
thanos_cache_dns_lookups_total
thanos_cache_dns_provider_results
thanos_cache_getmulti_gate_duration_seconds_bucket
thanos_cache_getmulti_gate_duration_seconds_count
thanos_cache_getmulti_gate_duration_seconds_sum
thanos_cache_getmulti_gate_queries_concurrent_max
thanos_cache_getmulti_gate_queries_in_flight
thanos_cache_hits_total
...

Describe the solution you'd like

Deprecate metrics with thanos_ prefix and add a new metrics with cortex_ prefix instead. We can use TeeRegisterer to achieve this.

Describe alternatives you've considered

Additional context

See this (internal link).

@pracucci
Copy link
Collaborator

We also expose Mimir metrics with cortex_ prefixed instead of mimir_ due to the same legacy reasons as with the thanos_ ones (nowadays Mimir doesn't vendor Thanos anymore). Unfortunately, doing a massive metrics renaming is a pain and so we ended up never doing it (yet).

@nabadger
Copy link

This would be very useful and would also be consistent with a similar change done in Tempo.

In particular it's a bit painful managing migrations from cortex to mimir because they can trigger each other's alerts (we could mitigate this in #5260 though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants