Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xtext grammar file is too large #756

Open
SimonCockx opened this issue May 20, 2024 · 1 comment
Open

Xtext grammar file is too large #756

SimonCockx opened this issue May 20, 2024 · 1 comment
Labels
maintenance Non-functional issue

Comments

@SimonCockx
Copy link
Contributor

SimonCockx commented May 20, 2024

Currently the whole grammar of Rune is defined in a single huge xtext file. This in turn leads to large derived Java classes, both generated (parser, sequencer, ...) and manually written (validator, formatter, ...).

Splitting up our grammar file can improve modularity, leading to more maintainable code. Additionally, projects using jacoco will stop seeing MethodTooLargeExceptions while building when they have the Rune DSL as a dependency.

I would propose the following splitting:

  • Rune types.
  • Rune expressions (extends Rune types).
  • Rune functions (extends Rune expressions).
  • Rune reporting (extends Rune expressions).
  • Rune translate (extends Rune expressions).
  • Rune (top layer interface, extends everything).
@SimonCockx SimonCockx added the maintenance Non-functional issue label May 20, 2024
@SimonCockx SimonCockx changed the title Xtext grammar files are too large Xtext grammar file is too large May 20, 2024
@cdietrich
Copy link

You should have a look in the workflow options to split classes eg the parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Non-functional issue
Projects
None yet
Development

No branches or pull requests

2 participants