Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create measurement units #466

Open
rocketstack-matt opened this issue Oct 11, 2024 · 0 comments
Open

Create measurement units #466

rocketstack-matt opened this issue Oct 11, 2024 · 0 comments
Labels

Comments

@rocketstack-matt
Copy link
Member

Feature Request

Description of Problem:

#457 introduced time-unit which allows us to record a time in a control-requirement, but we need to be able to also record what it is we need to do in that period of time.

e.g.

    "throughput": {
      "type": "object",
       "properties": {
         "expected-message-rate": {
           "$ref": "https://calm.finos.org/draft/2024-10/meta/units.json#/defs/time-unit",
           "description": "Define the expected message rate that the flow should handle e.g. 1000 per second"
         }
       },
       "required": [
         "expected-message-rate"
       ]
     }

We state how long the thing must take e.g.

  "throughput": {
     "expected-message-rate": {
       "value": 1000,
       "unit": "seconds"
     }
   }

But we haven't set what needs to happen in the time, other than by a vague interpretation of the property.

Potential Solutions:

  • Add a new definition which includes what it is that must happen (or be able to happen) in the time-unit and the value of that thing.
  • Alternatively we could create a new standalone value def and include it alongside the time-unit.

My preference would be for a new specific def per the first option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants