Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any fix to batched optimization? #3

Closed
TianningGao opened this issue Sep 8, 2023 · 2 comments
Closed

Any fix to batched optimization? #3

TianningGao opened this issue Sep 8, 2023 · 2 comments

Comments

@TianningGao
Copy link

I noticed there's a "batch_size" parameter for experiments.run_one_replication() but in experiments_util.get_acqf(), line 465 - 508, it will trigger some error on purpose if batch size is not 1. I tried to surpass the "batch_size == 1" condition but it triggers error elsewhere.

Is there any fix to enable batched optimization?

@Balandat
Copy link

I don't think we ran any batch sizes q > 1 for the paper, so I'm not sure this is expected to work here - @sdaulton?

In general it's not hard to support this, but this is an archival repo, and so we wouldn't make the changes here (and instead in the BoTorch PR here: pytorch/botorch#1533).

@TianningGao
Copy link
Author

Got it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants