Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py-tx] Upvote/Downbote/Matched Interfaces #1634

Open
Dcallies opened this issue Oct 1, 2024 · 0 comments
Open

[py-tx] Upvote/Downbote/Matched Interfaces #1634

Dcallies opened this issue Oct 1, 2024 · 0 comments
Assignees
Labels
hackathon Included as part of a recent hackathon python-threatexchange Items related to the threatexchange python tool / library

Comments

@Dcallies
Copy link
Contributor

Dcallies commented Oct 1, 2024

Add a SignalType interface for:

  1. Upvote/Downvote - aka Review Feedback
  2. Matched on platform - previously described as "seen"
  3. Upload

Which can be implemented by the existing interfaces. As of issue creation, there are multiple unsolved challenges with what this interface should be, due to the heterogeneous nature of the different interfaces.

Image

Of these, the easiest to handle is "Upload", since it can be done without worrying about the key type.

Likely the easiest way to attempt this:

  1. Split up the implementation of these methods between File (for testing), ThreatExchange, StopNCII, and NCMEC
  2. Implement the correct functionality in each of the clients first (e.g. the correct post requests)
  3. Come back together and find the minimum interface that satisfies all the inputs needed for each API

Attempted in #1630, but let's wait on the sub-issues first.

@Dcallies Dcallies self-assigned this Oct 1, 2024
@Dcallies Dcallies added python-threatexchange Items related to the threatexchange python tool / library hackathon Included as part of a recent hackathon labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackathon Included as part of a recent hackathon python-threatexchange Items related to the threatexchange python tool / library
Projects
Development

No branches or pull requests

1 participant