-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Suggestion] Allow disabling analytics rules and ignoring directories #606
Comments
You can use elm-analyse.json to disable rules and ignore directories . See
their documentation (yes, we also need to have that on our side)
That being said, the rule your speaking of, will default to off in the next
release.
Emil Goldsmith Olesen ***@***.***> schrieb am Do., 10. Juni
2021, 11:44:
… Expected Behavior
Hi! Thank you so much to all the contributors for the work you do! I may
be able to contribute to this change in the future, though not right now,
but just wanted to log this feature suggestion now.
My specific needs stem from:
- Wanting to disable the single field record analytics rule as I think
it can add a lot of important context to have a named argument in many
circumstances, but I don't want to fully disable the analytics as then I
for example lose the unused imports greying out in the editor etc.
- Wanting to ignore .elm-spa/generated which Elm SPA automatically
generates so I don't have problems with missing type annotations
showing up in my VSCode Problems tab
Current Behavior
Right now I can only enable or disable all analytics rules at once and
only for all files in my repo
Possible Solution
Think it's obvious from above :), for "related work" Elm Analytics has
these features so maybe code / implementation strategies could be borrowed
from there
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#606>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNLEZEDVZDTA6UATK4QII3TSCCP3ANCNFSM46N5REFQ>
.
|
Great about the default for the rule, but I already have an
elm-analyse.json and it works fine when I run elm analyse for example in
CI, but those errors still show in vscode
…On Thu, 10 Jun 2021 at 11.55, Kolja Lampe ***@***.***> wrote:
You can use elm-analyse.json to disable rules and ignore directories . See
their documentation (yes, we also need to have that on our side)
That being said, the rule your speaking of, will default to off in the next
release.
Emil Goldsmith Olesen ***@***.***> schrieb am Do., 10. Juni
2021, 11:44:
> Expected Behavior
>
> Hi! Thank you so much to all the contributors for the work you do! I may
> be able to contribute to this change in the future, though not right now,
> but just wanted to log this feature suggestion now.
>
> My specific needs stem from:
>
> - Wanting to disable the single field record analytics rule as I think
> it can add a lot of important context to have a named argument in many
> circumstances, but I don't want to fully disable the analytics as then I
> for example lose the unused imports greying out in the editor etc.
> - Wanting to ignore .elm-spa/generated which Elm SPA automatically
> generates so I don't have problems with missing type annotations
> showing up in my VSCode Problems tab
>
> Current Behavior
>
> Right now I can only enable or disable all analytics rules at once and
> only for all files in my repo
> Possible Solution
>
> Think it's obvious from above :), for "related work" Elm Analytics has
> these features so maybe code / implementation strategies could be
borrowed
> from there
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#606>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABNLEZEDVZDTA6UATK4QII3TSCCP3ANCNFSM46N5REFQ
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#606 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEKO66UWKJ6FLIO7VCGNUQDTSCDXJANCNFSM46N5REFQ>
.
|
Is the file next to the elm.json?
Emil Goldsmith Olesen ***@***.***> schrieb am Do., 10. Juni
2021, 15:14:
… Great about the default for the rule, but I already have an
elm-analyse.json and it works fine when I run elm analyse for example in
CI, but those errors still show in vscode
On Thu, 10 Jun 2021 at 11.55, Kolja Lampe ***@***.***> wrote:
> You can use elm-analyse.json to disable rules and ignore directories .
See
> their documentation (yes, we also need to have that on our side)
>
> That being said, the rule your speaking of, will default to off in the
next
> release.
>
> Emil Goldsmith Olesen ***@***.***> schrieb am Do., 10. Juni
> 2021, 11:44:
>
> > Expected Behavior
> >
> > Hi! Thank you so much to all the contributors for the work you do! I
may
> > be able to contribute to this change in the future, though not right
now,
> > but just wanted to log this feature suggestion now.
> >
> > My specific needs stem from:
> >
> > - Wanting to disable the single field record analytics rule as I think
> > it can add a lot of important context to have a named argument in many
> > circumstances, but I don't want to fully disable the analytics as then
I
> > for example lose the unused imports greying out in the editor etc.
> > - Wanting to ignore .elm-spa/generated which Elm SPA automatically
> > generates so I don't have problems with missing type annotations
> > showing up in my VSCode Problems tab
> >
> > Current Behavior
> >
> > Right now I can only enable or disable all analytics rules at once and
> > only for all files in my repo
> > Possible Solution
> >
> > Think it's obvious from above :), for "related work" Elm Analytics has
> > these features so maybe code / implementation strategies could be
> borrowed
> > from there
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub
> > <#606>, or
> > unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/ABNLEZEDVZDTA6UATK4QII3TSCCP3ANCNFSM46N5REFQ
> >
> > .
> >
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#606 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AEKO66UWKJ6FLIO7VCGNUQDTSCDXJANCNFSM46N5REFQ
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#606 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNLEZHWEPBJIMVXIWR4KXTTSC3D7ANCNFSM46N5REFQ>
.
|
Yep! At the root
…On Thu, 10 Jun 2021 at 18.16, Kolja Lampe ***@***.***> wrote:
Is the file next to the elm.json?
Emil Goldsmith Olesen ***@***.***> schrieb am Do., 10. Juni
2021, 15:14:
> Great about the default for the rule, but I already have an
> elm-analyse.json and it works fine when I run elm analyse for example in
> CI, but those errors still show in vscode
>
> On Thu, 10 Jun 2021 at 11.55, Kolja Lampe ***@***.***> wrote:
>
> > You can use elm-analyse.json to disable rules and ignore directories .
> See
> > their documentation (yes, we also need to have that on our side)
> >
> > That being said, the rule your speaking of, will default to off in the
> next
> > release.
> >
> > Emil Goldsmith Olesen ***@***.***> schrieb am Do., 10. Juni
> > 2021, 11:44:
> >
> > > Expected Behavior
> > >
> > > Hi! Thank you so much to all the contributors for the work you do! I
> may
> > > be able to contribute to this change in the future, though not right
> now,
> > > but just wanted to log this feature suggestion now.
> > >
> > > My specific needs stem from:
> > >
> > > - Wanting to disable the single field record analytics rule as I
think
> > > it can add a lot of important context to have a named argument in
many
> > > circumstances, but I don't want to fully disable the analytics as
then
> I
> > > for example lose the unused imports greying out in the editor etc.
> > > - Wanting to ignore .elm-spa/generated which Elm SPA automatically
> > > generates so I don't have problems with missing type annotations
> > > showing up in my VSCode Problems tab
> > >
> > > Current Behavior
> > >
> > > Right now I can only enable or disable all analytics rules at once
and
> > > only for all files in my repo
> > > Possible Solution
> > >
> > > Think it's obvious from above :), for "related work" Elm Analytics
has
> > > these features so maybe code / implementation strategies could be
> > borrowed
> > > from there
> > >
> > > —
> > > You are receiving this because you are subscribed to this thread.
> > > Reply to this email directly, view it on GitHub
> > > <#606>, or
> > > unsubscribe
> > > <
> >
>
https://github.com/notifications/unsubscribe-auth/ABNLEZEDVZDTA6UATK4QII3TSCCP3ANCNFSM46N5REFQ
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <
>
#606 (comment)
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AEKO66UWKJ6FLIO7VCGNUQDTSCDXJANCNFSM46N5REFQ
> >
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#606 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABNLEZHWEPBJIMVXIWR4KXTTSC3D7ANCNFSM46N5REFQ
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#606 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEKO66WBZBU7I2GVLWB3J6LTSDQMFANCNFSM46N5REFQ>
.
|
Can you setup an example repo where this reproduces? It's really hard to see why this fails otherwise. |
I’ll try making the time, and get back to you if I do!
…On Fri, 11 Jun 2021 at 12.05, Kolja Lampe ***@***.***> wrote:
Can you setup an example repo where this reproduces? It's really hard to
see why this fails otherwise.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#606 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEKO66STMKHNRLGNIYHSHA3TSHNXRANCNFSM46N5REFQ>
.
|
I'm also interested in this. We have an
The plugin works fine up until version 1.5.3, but for versions 2.0.0 and above I get a bunch of errors listed in the |
No, in fact I just setup a test repo with that config and was able to confirm, that excludedPaths work on Linux with the latest release. |
Thanks for the quick response. I figured out what my problem was (not really related to this issue, but perhaps useful nonetheless): Turned out I had an old |
Expected Behavior
Hi! Thank you so much to all the contributors for the work you do! I may be able to contribute to this change in the future, though not right now, but just wanted to log this feature suggestion now.
My specific needs stem from:
problems
with missing type annotations showing up in my VSCodeProblems
tabCurrent Behavior
Right now I can only enable or disable all analytics rules at once and only for all files in my repo
Possible Solution
Think it's obvious from above :), for "related work" Elm Analytics has these features so maybe code / implementation strategies could be borrowed from there
The text was updated successfully, but these errors were encountered: