Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put *_internal_* things in separate header #614

Open
yellowhatter opened this issue Aug 22, 2024 · 2 comments
Open

Put *_internal_* things in separate header #614

yellowhatter opened this issue Aug 22, 2024 · 2 comments
Labels
internal Changes not included in the changelog

Comments

@yellowhatter
Copy link
Contributor

Describe the feature

After implementing *_internal_* functions, it looks wise to put all internal stuff to separate zenoh_internal.h that is not included by default in zenoh.h
@yellowhatter
Copy link
Contributor Author

@milyin @Mallets @DenisBiryukov91

@DenisBiryukov91
Copy link
Contributor

It makes sense, but it will likely still be exposed by default for example in pico/zenoh-cpp, due to transitive header inclusion.

@milyin milyin added the internal Changes not included in the changelog label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal Changes not included in the changelog
Projects
Zenoh 1.0.0 release
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@milyin @yellowhatter @DenisBiryukov91