Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory tracking for JSON data type #3661

Closed
kostasrim opened this issue Sep 6, 2024 · 3 comments
Closed

Memory tracking for JSON data type #3661

kostasrim opened this issue Sep 6, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@kostasrim
Copy link
Contributor

Our tracking for JSON is buggy. First no matter the size of the json will always report 16 bytes per object. Second we don't track the internal memory used by Json objects.

The fix is simple but the pmr in jsoncons library is buggy as well.

I am creating this issue to:

  1. Track the bug/issue reported on jsoncons lib
  2. Once (1) is resolved merge my pr
@kostasrim kostasrim added the bug Something isn't working label Sep 6, 2024
@kostasrim
Copy link
Contributor Author

@romange
Copy link
Collaborator

romange commented Sep 6, 2024

@kostasrim if you happen to know how to fix the issue, we do not need to wait for Daniel to fix it in his repo - we use our own fork - https://github.com/dragonflydb/jsoncons/tree/Dragonfly
which also btw is very much behind jsoncons.

  1. It could be that their latest release already fixes the issue
  2. we could also potentially patch Dragonfly with the fix. But if the fix is complicated - no need to spend too much time on it and we will patiently wait on it a few more months.

@kostasrim
Copy link
Contributor Author

  1. I did not know we use our own fork
  2. Yes I think I can patch this fairly fast (which I will then send as a PR to them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants