Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of test_function_definition #346

Open
filipsch opened this issue Sep 7, 2018 · 0 comments
Open

Get rid of test_function_definition #346

filipsch opened this issue Sep 7, 2018 · 0 comments

Comments

@filipsch
Copy link
Contributor

filipsch commented Sep 7, 2018

test_function_definition() is responsible for a lot of code in pythonwhat. If we get rid of this function, we can remove call() and test_function_definition() from the API. This would involve rewriting some SCTs though, for 39 exercises to be precise:

  course_id count link                                 
      <int> <int> <chr>                                
1      1392     6 https://www.datacamp.com/courses/1392
2      1531     2 https://www.datacamp.com/courses/1531
3      1532    15 https://www.datacamp.com/courses/1532
4      1549     4 https://www.datacamp.com/courses/1549
5      1550     4 https://www.datacamp.com/courses/1550
6      1650     3 https://www.datacamp.com/courses/1650
7      1822     5 https://www.datacamp.com/courses/1822

Not the most fun work, but it would make future maintenance and understanding of the package a lot easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant