Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a library to a volume goes to internal directory #1838

Open
fernanluyano opened this issue Oct 18, 2024 · 2 comments
Open

Adding a library to a volume goes to internal directory #1838

fernanluyano opened this issue Oct 18, 2024 · 2 comments
Labels
DABs DABs related issues Response Requested

Comments

@fernanluyano
Copy link

When uploading a JAR to a Volume, it's put in an ".internal" directory instead of the volume path I provided.
E.g., where the libraries_volume variable is of the form /Volumes/...

workspace:
  root_path: /Users/${workspace.current_user.userName}/.bundle/${bundle.name}
  artifact_path: ${var.libraries_volume}

artifacts:
  jobs_jar:
    files:
      - source: "workflows-fat-jar-*.jar"
    type: jar
@fernanluyano fernanluyano added the DABs DABs related issues label Oct 18, 2024
@andrewnester
Copy link
Contributor

Artifacts are indeed always put in .internal folder in artifact path created by DABs. The reason is that we want to be able safely clean everything that DABs created if needed, in this case we can safely remove .internal folder.

What's your concern with having .internal folder?

@fernanluyano
Copy link
Author

fernanluyano commented Oct 18, 2024

There is no direct concern. But it’s a bit obscure since I’d expect it to go to the location I told it to, in a volume. It makes clients be aware of it when pointing to a library location inside the volume, in a job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DABs DABs related issues Response Requested
Projects
None yet
Development

No branches or pull requests

2 participants