Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for scoped packages #5

Open
micahjon opened this issue May 15, 2019 · 2 comments · May be fixed by #6
Open

Add support for scoped packages #5

micahjon opened this issue May 15, 2019 · 2 comments · May be fixed by #6
Labels
enhancement New feature or request

Comments

@micahjon
Copy link

First of all, thanks for this super nifty extension.

I noticed it wasn't working well for scoped packages: @orgname/packagename
https://www.npmjs.com/package/@babel/core
https://www.npmjs.com/package/@webcomponents/template

So I forked it and tweaked getPackageName() to handle this case. If you'd like me to submit a PR, I'd be happy to. micahjon@eb4066b
@cristianbote cristianbote added the enhancement New feature or request label May 15, 2019
@cristianbote
Copy link
Owner

Hey @pranksinatra thanks for submitting this really appreciate it! 😄
It looks awesome! Feel free to open a PR when you're ready. Looking forward!

@micahjon
Copy link
Author

Sweet, just submitted PR #6

@micahjon micahjon linked a pull request May 16, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for scoped packages micahjon/bundlephobia-extension
2 participants
@cristianbote @micahjon