Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Overriding optional bosh link consumers in the deployment manifest doesn't seem to work #1259

Open
jandubois opened this issue Dec 7, 2020 · 2 comments
Labels
bug Something isn't working unscheduled

Comments

@jandubois
Copy link
Member

The docs at https://bosh.io/docs/links/#explicit state:

Optional consumers may be specified as nil in the deployment manifest to block consumption of any providers.

In kubecf we have done this to disable link resolution for postgres for the credhub instance group. Looking at desired-manifest-v1 shows:

      jobs:
      - consumes:
          postgres: null
        name: credhub

However, ig-resolved.credhub-v1 still references the autoscaler database:

          quarks:
            consumes:
              postgres:
                address: asdatabase

We've ultimately worked around this with an ig_resolver patch, modifying the job.MF of the credhub job, but I think the explicit link resolution should have worked as well.

@jandubois jandubois added the bug Something isn't working label Dec 7, 2020
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/176045869

The labels on this github issue will be updated when the story is started.

jandubois added a commit to cloudfoundry-incubator/kubecf that referenced this issue Dec 7, 2020
…edhub.

This fix doesn't seem to work; most likely because quarks-operator doesn't
implement the functionality:

> Optional consumers may be specified as nil in the deployment manifest
> to block consumption of any providers.

See cloudfoundry-incubator/quarks-operator#1259

We are going to keep this change because we expect this to be fixed
in the operator eventually.
@f0rmiga
Copy link
Member

f0rmiga commented Dec 14, 2020

Ping @manno in case you missed this. I see that the Pivotal Tracker issue was not scheduled yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working unscheduled
Projects
None yet
Development

No branches or pull requests

3 participants