Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retype the filed from msat from String to int #74

Open
vincenzopalazzo opened this issue Jun 20, 2022 · 0 comments
Open

retype the filed from msat from String to int #74

vincenzopalazzo opened this issue Jun 20, 2022 · 0 comments
Labels
bug fixing c-ln-feature New feature of c-lighthning to be supported in the library good first issue Good for newcomers Hacktoberfest new lightningd version Adding support to the new version of lightningd refactoring refactoring code
Milestone
v0.3.0

Comments

@vincenzopalazzo
Copy link
Member

The change implemented in the PR ElementsProject/lightning#5306 happens from the next release, so the solution is to break the type and move all msat filed from String to integer.

We need to decide only if we want to support both or just the last version, commenting on the PR if you want discuss it before stat to working on it
@vincenzopalazzo vincenzopalazzo added good first issue Good for newcomers new lightningd version Adding support to the new version of lightningd bug fixing refactoring refactoring code c-ln-feature New feature of c-lighthning to be supported in the library Hacktoberfest labels Jun 20, 2022
@vincenzopalazzo vincenzopalazzo added this to the v0.3.0 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixing c-ln-feature New feature of c-lighthning to be supported in the library good first issue Good for newcomers Hacktoberfest new lightningd version Adding support to the new version of lightningd refactoring refactoring code
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
1 participant
@vincenzopalazzo