Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for configurable retry-count #510

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

schmod
Copy link

@schmod schmod commented Aug 8, 2023

Issue #, if available: #502

Description of changes:
Adds support for a configurable number of retries (particularly for rate-limit errors).


If we were using aws-sdk-js V3, we'd be able to do this with environment variables, but that's probably a larger change than we want to make here, as there may be folks who are indirectly depending on features of the V2 SDK.


✅ By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

closes #502

@schmod
Copy link
Author

schmod commented Aug 10, 2023

I've been running this on my fork for a few days, and it seems to work!

@schmod
Copy link
Author

schmod commented Oct 25, 2023

bump

@amazreech
Copy link
Contributor

Hi @schmod,

Thank you for your Patience. We appreciate your contribution to the repository and will be working to review the changes in the Pull Request. We will reach-out if with any questions or suggestions during the review.

In the meantime please ensure that below steps, if not already completed, are taken care of in your Pull Request:

  1. Verify if PR follows semantic pull request conventions.
    Example: please make sure the PR title follows the convention.

  2. Please run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve any merge conflicts on the PR

@@ -282,6 +276,15 @@ async function run() {
const desiredCount = parseInt((core.getInput('desired-count', {required: false})));


const ecs = new aws.ECS({
Copy link
Contributor

@trivikr trivikr May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to be rebased to use AWS SDK for JavaScript (v3) which uses maxAttempts

Refer: #529

@rantoniuk
Copy link

@amazreech really? After 6+ months you're asking the contributor to rebase? That's not how contributions are supposed to work.

Assuming the PR is valid and introduced a wanted new functionality, I'd expect that if the maintainers don't have the capacity to review within 1-2 months, then they should spend some time rebasing the PR themselves. After almost a year the contributor might be far away doing a totally different work! (yes, I maintain some repositories as well and this is exactly what I do).

@trivikr
Copy link
Contributor

trivikr commented Jun 22, 2024

I'm not a maintainer of this repo, but a contributor like yourself. I just spent some time to go through other open PRs which were impacted because of my change, and commented on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: retry upon Rate exceeded error
5 participants