From 092c22674d4142709a3760f7b3a523a8f5d37dbb Mon Sep 17 00:00:00 2001 From: rymarm Date: Wed, 18 Sep 2024 21:12:45 +0300 Subject: [PATCH 1/2] DRILL-8511: Overflow appeared when the batch reached rows limit --- .../drill/exec/vector/accessor/writer/BitColumnWriter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BitColumnWriter.java b/exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BitColumnWriter.java index 43cae140070..427869299ab 100644 --- a/exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BitColumnWriter.java +++ b/exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BitColumnWriter.java @@ -84,7 +84,7 @@ private void prepareWrite(int writeIndex) { @Override public void setValueCount(int valueCount) { - prepareWrite(valueCount); + prepareWrite(valueCount - 1); mutator.setValueCount(valueCount); } From dfdc913a3786e3a8e0c01bfc70415d5db348b41f Mon Sep 17 00:00:00 2001 From: rymarm Date: Mon, 23 Sep 2024 15:51:55 +0300 Subject: [PATCH 2/2] Resolve bug tests caught --- .../drill/exec/vector/accessor/writer/BitColumnWriter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BitColumnWriter.java b/exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BitColumnWriter.java index 427869299ab..6d980b1888f 100644 --- a/exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BitColumnWriter.java +++ b/exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BitColumnWriter.java @@ -60,7 +60,7 @@ protected int prepareWrite() { // Please be thoughtful when changing the code. final int writeIndex = vectorIndex.vectorIndex(); - prepareWrite(writeIndex); + prepareWrite(writeIndex - 1); // Track the last write location for zero-fill use next time around.