Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Kubernetes - execute complex jobs with sidecar containers etc etc #16685

Open
2 of 3 tasks
giovannidalloglio opened this issue Oct 10, 2024 · 3 comments
Open
2 of 3 tasks
Labels
discussion discussion improvement make more easy to user or prompt friendly

Comments

@giovannidalloglio
Copy link

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Hello.

Do you fully support the kubernetes Job api?

In the documentation (https://dolphinscheduler.apache.org/en-us/docs/3.2.2/guide/task/kubernetes) i just see the option to specify a single container.

But various "enterprise" scenarios require the full set of options (https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/).

As example, in our environment we need a "worker" container, and two differente sidecar containers (one of them is the "tunnel" to the DB, etc...)

Is it possibile to run those kind of jobs?

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@giovannidalloglio giovannidalloglio added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply labels Oct 10, 2024
@SbloodyS
Copy link
Member

cc @Gallardot

@SbloodyS SbloodyS added discussion discussion and removed Waiting for reply Waiting for reply labels Oct 11, 2024
@SbloodyS SbloodyS changed the title Improvement Kubernetes - execute complex jobs with sidecar containers etc etc [Improvement] Kubernetes - execute complex jobs with sidecar containers etc etc Oct 11, 2024
@Gallardot
Copy link
Member

@giovannidalloglio

Currently, not all capabilities and features of K8S Job are fully supported.
At present, only the definition of a single container in spec.template.spec.containers is supported; multiple container definitions are not supported.
Perhaps in the future, we can allow users to customize the spec.template of the Job, but this is not supported at the moment.

In my personal understanding, Sidecars belong to the general capabilities of the infrastructure and should not be customized by users. Administrator can use tools like gatekeeper to inject more custom features.

cc @fuchanghai @Mighten @SbloodyS @ruanwenjun

@SbloodyS
Copy link
Member

@giovannidalloglio

Currently, not all capabilities and features of K8S Job are fully supported. At present, only the definition of a single container in spec.template.spec.containers is supported; multiple container definitions are not supported. Perhaps in the future, we can allow users to customize the spec.template of the Job, but this is not supported at the moment.

In my personal understanding, Sidecars belong to the general capabilities of the infrastructure and should not be customized by users. Administrator can use tools like gatekeeper to inject more custom features.

cc @fuchanghai @Mighten @SbloodyS @ruanwenjun

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion discussion improvement make more easy to user or prompt friendly
Projects
None yet
Development

No branches or pull requests

3 participants