Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-72][Dynamic Task] Suggest remove dynamic task type #16591

Open
2 tasks done
Tracked by #14102
SbloodyS opened this issue Sep 5, 2024 · 12 comments
Open
2 tasks done
Tracked by #14102

[DSIP-72][Dynamic Task] Suggest remove dynamic task type #16591

SbloodyS opened this issue Sep 5, 2024 · 12 comments
Labels

Comments

@SbloodyS
Copy link
Member

SbloodyS commented Sep 5, 2024

Search before asking

  • I had searched in the DSIP and found no similar DSIP.

Motivation

The dynamic task type is currently supported in a user-configured manner. The user executes a while like loop to determine the exit condition. After the exit, specify multiple times of sub-workflows based on exit conditions.

The current task type has a lot of bugs, and I think the operation of executing multiple times of sub-workflows is not universal, and it is too customized for a certain business scenario. And at the same time, I search in the issue list found that only a single digit of users were using it.

So I suggest remove this dynamic task type.

Design Detail

No response

Compatibility, Deprecation, and Migration Plan

No response

Test Plan

No response

Code of Conduct

@SbloodyS SbloodyS added the DSIP label Sep 5, 2024
@SbloodyS SbloodyS changed the title [DSIP-][Dynamic Task] Suggest remove dynamic task type [DSIP][Dynamic Task] Suggest remove dynamic task type Sep 5, 2024
@SbloodyS SbloodyS added the discussion discussion label Sep 5, 2024
@caishunfeng
Copy link
Contributor

+1

1 similar comment
@EricGao888
Copy link
Member

+1

@zhongjiajie
Copy link
Member

+1, and because of this issue try to remove an existing plugin for our product, and as I remember we do not remove anyone before. can we add some docs and guide someone who wants to remove other plugins? Such as we have to discuss in issue or mail thread, or we only remove plugin in major or minor version?

@SbloodyS
Copy link
Member Author

SbloodyS commented Sep 5, 2024

+1, and because of this issue try to remove an existing plugin for our product, and as I remember we do not remove anyone before. can we add some docs and guide someone who wants to remove other plugins? Such as we have to discuss in issue or mail thread, or we only remove plugin in major or minor version?

I think we should remove plugin only in major version.

@SbloodyS SbloodyS changed the title [DSIP][Dynamic Task] Suggest remove dynamic task type [DSIP-72][Dynamic Task] Suggest remove dynamic task type Sep 5, 2024
@zhongjiajie
Copy link
Member

+1, and because of this issue try to remove an existing plugin for our product, and as I remember we do not remove anyone before. can we add some docs and guide someone who wants to remove other plugins? Such as we have to discuss in issue or mail thread, or we only remove plugin in major or minor version?

I think we should remove plugin only in major version.

Agree with that, and we can add some deprecated notice for those task we remove in dev branch but still not released, WDYT

@SbloodyS
Copy link
Member Author

SbloodyS commented Sep 6, 2024

Agree with that, and we can add some deprecated notice for those task we remove in dev branch but still not released, WDYT

Yes, we've already add it to the docs in https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/guide/upgrade/incompatible.md

@ruanwenjun
Copy link
Member

+1

@lenboo
Copy link
Contributor

lenboo commented Sep 24, 2024

@SbloodyS
Hi SbloodyS.
Can I understand that if a feature is found to have some bugs and has few users, then it can be removed?

@SbloodyS
Copy link
Member Author

@SbloodyS Hi SbloodyS. Can I understand that if a feature is found to have some bugs and has few users, then it can be removed?

I think no PMC/Committer is willing to continue to maintain, and at the same time, there are bugs that are not fixed and rarely used. Then we will remove it. The situation is similar to that of #16093.

@lenboo
Copy link
Contributor

lenboo commented Sep 24, 2024

That means if someone is willing to fix these bugs and the fixes pass verification, then the feature can be retained and not removed.

@SbloodyS
Copy link
Member Author

That means if someone is willing to fix these bugs and the fixes pass verification, then the feature can be retained and not removed.

Yes.

@lenboo
Copy link
Contributor

lenboo commented Sep 24, 2024

I will look for someone in the community who is willing to fix these bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants