Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: terms & conditions checkbox should be 'required' on register form #49

Open
Rahulm2310 opened this issue Mar 22, 2021 · 6 comments
Open
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. First Timers Only Good for newcomers. Type: Bug Bug or Bug fixes.

Comments

@Rahulm2310
Copy link
Contributor

Rahulm2310 commented Mar 22, 2021

Describe the bug

User is allowed to submit register form without accepting the terms and conditions.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://anitab-org.github.io/stem-diverse-tv-cms/register
  2. Enter user details
  3. Let the checkbox for terms and conditions unchecked.
  4. See error

Expected behavior

User should be prompted to accept the terms and conditions (add required prop to the checkbox).

Screenshots

stem-checkbox

Desktop (please complete the following information):

  • OS:Any
  • Browser: Any
  • Version: Any
@Rahulm2310 Rahulm2310 changed the title Bug: make the terms & conditions checkbox 'required on register form Bug: terms & conditions checkbox should be 'required' on register form Mar 22, 2021
@Rahulm2310 Rahulm2310 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. First Timers Only Good for newcomers. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Bug Bug or Bug fixes. labels Mar 24, 2021
@VenomFate-619
Copy link

can I fix it?

@isabelcosta
Copy link
Member

@VenomFate-619 sure! I will assign this to you :)

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Sep 11, 2021
@VenomFate-619
Copy link

It is seen to be already fixed .
it is working correctly both on live site and locally
Code for reference
<Checkbox color="primary" name="termsAndConditionChecked" onChange={() => setTermsAndConditions(!termsAndConditionChecked)} required />

On production website :-
image
On developing website :-
image

@VenomFate-619
Copy link

A new bug is created, although I clicked the checkbox but also the error message is displayed.

image

ss from the network tab

image

I think the error is from frontend it is not sending proper property value for that purpose

@isabelcosta
Copy link
Member

@VenomFate-619 would you like to create an issue for this error you mentioned?

@VenomFate-619
Copy link

VenomFate-619 commented Sep 14, 2021

Yes, I would like to.
I had created a new error , can you assign it to me #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. First Timers Only Good for newcomers. Type: Bug Bug or Bug fixes.
Projects
None yet
Development

No branches or pull requests

4 participants