Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parquetAnalyzeForeignTable does not set totalpages #30

Open
sdressler opened this issue Mar 1, 2021 · 0 comments
Open

parquetAnalyzeForeignTable does not set totalpages #30

sdressler opened this issue Mar 1, 2021 · 0 comments

Comments

@sdressler
Copy link

sdressler commented Mar 1, 2021

The function parquetAnalyzeForeignTable does not assign a value to totalpages. This is however needed for estimation (most notably in parquetGetForeignRelSize).

Proposed implementation (pseudocode):

total_byte_size = 0;
foreach pq_file in files do
  total_byte_size += SumRowGroupSizes(pq_file);
end
*totalpages = total_byte_size / BLCKSZ;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant