From be566ab1cabca6b0eb4945e25e4fe866a2ef56bb Mon Sep 17 00:00:00 2001
From: Jonas Wielage <jonas.wielage@sonarsource.com>
Date: Mon, 25 Sep 2023 11:49:55 +0200
Subject: [PATCH] Remove sonar-issues due to extended Quality Gate (#282)

---
 .../org/sonar/plugins/secrets/api/PostFilterFactory.java  | 8 +++++---
 .../sonar/plugins/secrets/api/SpecificationLoader.java    | 1 -
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/sonar-text-plugin/src/main/java/org/sonar/plugins/secrets/api/PostFilterFactory.java b/sonar-text-plugin/src/main/java/org/sonar/plugins/secrets/api/PostFilterFactory.java
index ce4833d22..897436d0d 100644
--- a/sonar-text-plugin/src/main/java/org/sonar/plugins/secrets/api/PostFilterFactory.java
+++ b/sonar-text-plugin/src/main/java/org/sonar/plugins/secrets/api/PostFilterFactory.java
@@ -52,15 +52,17 @@ public static Predicate<String> createPredicate(@Nullable PostModule post, @Null
 
   static Predicate<String> filterForPatternNot(List<String> patternNot) {
     String pipedPatterns = pipePatternNot(patternNot);
+    var compiledPatternNot = Pattern.compile(pipedPatterns);
+
     return candidateSecret -> {
-      Matcher matcher = Pattern.compile(pipedPatterns).matcher(candidateSecret);
+      var matcher = compiledPatternNot.matcher(candidateSecret);
       return !matcher.find();
     };
   }
 
   static String pipePatternNot(List<String> patternNot) {
-    StringBuilder sb = new StringBuilder();
-    for (int i = 0; i < patternNot.size(); i++) {
+    var sb = new StringBuilder();
+    for (var i = 0; i < patternNot.size(); i++) {
       sb.append("(?:");
       sb.append(patternNot.get(i));
       sb.append(")");
diff --git a/sonar-text-plugin/src/main/java/org/sonar/plugins/secrets/api/SpecificationLoader.java b/sonar-text-plugin/src/main/java/org/sonar/plugins/secrets/api/SpecificationLoader.java
index 6eca4408b..5fd2c1ce0 100644
--- a/sonar-text-plugin/src/main/java/org/sonar/plugins/secrets/api/SpecificationLoader.java
+++ b/sonar-text-plugin/src/main/java/org/sonar/plugins/secrets/api/SpecificationLoader.java
@@ -25,7 +25,6 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.sonar.plugins.secrets.configuration.deserialization.DeserializationException;