-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] webkitgtk: log_path -> log_output #14618
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
f0f9ea5
to
f504648
Compare
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Changes
log_path
tolog_output
because it is an outdated parameter andlog_output
is the updated parameterMotivation and Context
super.__init__
still callslog_file
which is not there anymore so this PR updates it tolog_output
.Types of changes
Checklist
PR Type
enhancement
Description
log_path
tolog_output
in theService
class to reflect updated naming conventions.log_output
parameter, ensuring compatibility with the updated API.super.__init__
was incorrectly referencing a non-existentlog_file
.Changes walkthrough 📝
service.py
Update parameter from `log_path` to `log_output` in Service class
py/selenium/webdriver/webkitgtk/service.py
log_path
tolog_output
.log_output
instead oflog_file
.