-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Implement add_request_handler #14604
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Currently, the |
820fee6
to
8fbc580
Compare
It was |
bac8478
to
9c0bed1
Compare
|
All local @VietND96 May the workflow be triggered again? |
9c0bed1
to
1b0a879
Compare
@AutomatedTester I would really appreciate your feedback on this. In particular, what are your thoughts on
|
User description
Description
Implement add_request_handler as described in #13993.
Add CDDL structures generated from the BIDI specs
Add an asynchronous navigation function
driver.network.get
Motivation and Context
#13993
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
add_request_handler
method.Changes walkthrough 📝
network.py
Implement network request handling and serialization classes
py/selenium/webdriver/common/bidi/network.py
script.py
Add stack trace data classes with serialization
py/selenium/webdriver/common/bidi/script.py
StackFrame
andStackTrace
data classes.network.py
Introduce Network class for request management
py/selenium/webdriver/remote/network.py
Network
class for managing network requests.add_request_handler
method for request interception.webdriver.py
Integrate Network class into WebDriver
py/selenium/webdriver/remote/webdriver.py
Network
class into WebDriver.network
property for network operations.bidi_network_tests.py
Add tests for network request handler
py/test/selenium/webdriver/common/bidi_network_tests.py
add_request_handler
method.