Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix map boundaries problem on certain screen sizes #41

Open
alexander-bauer opened this issue Jun 19, 2013 · 7 comments
Open

Fix map boundaries problem on certain screen sizes #41

alexander-bauer opened this issue Jun 19, 2013 · 7 comments
Labels
bug front-end

Comments

@alexander-bauer
Copy link
Member

screenshot - 06192013 - 12 19 51 am
lukevers added a commit that referenced this issue Jun 21, 2013
@lukevers
Adding nodes works with the new layout.
ac7ce11 
It's using the old modal, which is fine.
Still some things need to be worked on.

Ref #41
Ref #42
Ref #43
lukevers added a commit that referenced this issue Jun 21, 2013
@lukevers
Finalized some changes on the new design.
3c400c1 
Ref #41
Ref #42
Ref #43

Closes #43
@alexander-bauer
Copy link
Member Author

This is a high priority issue.

@lukevers
Copy link
Member

lukevers commented Jul 9, 2013

I'm pretty sure this issue can be closed now, but if someone thinks otherwise, then they can reopen and show proof to what's going on with their browser and we'll go from there.

@lukevers lukevers closed this as completed Jul 9, 2013
@alexander-bauer
Copy link
Member Author

I still have this issue.

screenshot - 07092013 - 07 38 41 pm

@lukevers
Copy link
Member

@SashaCrofter, now that we have the navbar at the top, do you still experience this issue?

@alexander-bauer
Copy link
Member Author

Yeah, I still have this problem to an extent. When first loading the map, before zooming out, the lowest row of tiles doesn't display.

screenshot - 07182013 - 01 35 18 pm

@lukevers
Copy link
Member

I'm curious if this is not our problem but a Leaflet problem in itself. Also, as a side note, there's no most recent image of what the new navbar looks like (although I think the map basically stayed the same since it last changed), but this thread seems to be a cool example of the history of NodeAtlas design.

@lukevers
Copy link
Member

lukevers commented Mar 2, 2014

@SashaCrofter what is your screen size? I have a few ideas on how to fix this, but one of the ideas has to do with non-standard screen sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug front-end
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexander-bauer @lukevers