Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect code for bugs that are not covered by tests #40

Open
warpech opened this issue Jun 6, 2019 · 1 comment
Open

Inspect code for bugs that are not covered by tests #40

warpech opened this issue Jun 6, 2019 · 1 comment

Comments

@warpech
Copy link
Contributor

warpech commented Jun 6, 2019

After #39

The code in https://github.com/Palindrom/JSONPatcherProxy/blob/c461b492a4fa2e2869ba99cbe0329db3846e93cd/src/jsonpatcherproxy.js contains several TODO statements that mark places for functionality that is not tested.

Also check why running the test suite results in so many console loigs. Is this by design, or are some of these console logs actually pointing out a problem:

λ npm run test

> [email protected] test W:\repo\JSONPatcherProxy
> jasmine DUPLEX=proxy JASMINE_CONFIG_PATH=test/jasmine.json

Started
...........You're accessing an object that is detached from the observedObject tree, see https://github.com/Palindrom/JSONPatcherProxy#detached-objects
..JSONPatcherProxy noticed a non-integer prop was set for an array. This will not emit a patch
JSONPatcherProxy noticed a non-integer prop was set for an array. This will not emit a patch
.....JSONPatcherProxy noticed a non-integer prop was set for an array. This will not emit a patch
JSONPatcherProxy noticed a non-integer prop was set for an array. This will not emit a patch
.........................You're accessing an object that is detached from the observedObject tree, see https://github.com/Palindrom/JSONPatcherProxy#detached-objects
You're accessing an object that is detached from the observedObject tree, see https://github.com/Palindrom/JSONPatcherProxy#detached-objects
.......
@warpech
Copy link
Contributor Author

warpech commented Jun 6, 2019

Regarding the TODO in the line

this._isProxifyingTreeNow = true; //TODO probably not needed, when I comment this out, all tests pass
, do not miss the comment in #39 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant