"Packing was skipped because ... doesn't have a <PackageLicenseFile> property." when the license file comes from a nuspec template (OSOE-639)

[Piedone]

Case in point for Lombiq .NET Analyzers: It uses a ConvertTo-Nuspec.ps1 script to add the following element with a reference to the license file:

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
    <metadata>
        <license type="file">License.md</license>
    </metadata>
</package>

This is valid but causes New-NuGetPackage.ps1 to throw the above warning because it looks specifically for the //PropertyGroup/PackageLicenseFile element. Rather, it should support the above notation too.

Once this is fixed, remove the workaround from Lombiq.Analyzers.

Jira issue