Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get_devices() function? #33

Open
JonnyJD opened this issue Jun 17, 2013 · 3 comments
Open

add get_devices() function? #33

JonnyJD opened this issue Jun 17, 2013 · 3 comments
Labels

Comments

@JonnyJD
Copy link
Owner

JonnyJD commented Jun 17, 2013

This is somewhat related to #30, but different in my eyes.
DEFAULT_DEVICE or get_default_device() (depending on outcome of #30) is about the actual default and should stay as a feature due to haveing discid_get_default_device() returning a single string in libdiscid.

get_devices() would get a list of currently (or in general) available devices, which probably should include the one default.
This function is basically implemented in https://github.com/musicbrainz/picard/blob/master/picard/util/cdrom.py (as a list of currently available devices) for Windows and Linux.
An implementation for Mac OS X is partly implemented in isrcsubmit:
https://github.com/JonnyJD/musicbrainz-isrcsubmit/blob/bdb8efc2a6819d791dce198879bde34846c95d07/isrcsubmit.py#L301 (using drutil)

Part of this is implemented in libdiscid for Mac (for default_device) and proposed for Windows:
metabrainz/libdiscid#20.

@JonnyJD
Copy link
Owner Author

JonnyJD commented Jun 17, 2013

I see no reason this has to go into the first stable release. So this would be 1.1.0 the earliest.

@zas
Copy link

zas commented Jun 18, 2013

Yes, it shouldn't block 1.0 release, but this is a nice addition to have imho.

@Freso
Copy link
Collaborator

Freso commented Feb 18, 2017

I'm messing with a freedb2musicbrainz.py script right now, and I might want functionality similar to this as well, so it would be nice to have here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants